Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upd(librewolf-app): 119.0.1-1 -> 120.0.1-1 #5058

Closed
wants to merge 5 commits into from
Closed

upd(librewolf-app): 119.0.1-1 -> 120.0.1-1 #5058

wants to merge 5 commits into from

Conversation

vigress8
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the Update Package Use this to request pacscript update label Dec 19, 2023
@vigress8
Copy link
Collaborator Author

/var/lib/dpkg/info/librewolf-app.postrm: line 60: return: can only `return' from a function or sourced script
@oklopfer any clue what this is about?

@oklopfer
Copy link
Member

Looks to be due to the previous maintainer's removal script integrating the ask function. We can probably rewrite it internally in the package.

@vigress8
Copy link
Collaborator Author

I removed ask and re-implemented the question, but the error persists. Is this an issue with post_remove in general?

@oklopfer
Copy link
Member

@Elsie19 any ideas?

@Elsie19
Copy link
Member

Elsie19 commented Dec 19, 2023

/var/lib/dpkg/info/librewolf-app.postrm: line 60: return: can only `return' from a function or sourced script
@oklopfer any clue what this is about?

it means somewhere outside of a function it's running return, which bash doesn't like.

@vigress8
Copy link
Collaborator Author

@Elsie19 so how can this be fixed?

hash="af10277447c2c469d3b6c6a4ea99460de90346edfd8515066a317a954659e0f4"
;;
*) return 1 ;;
esac
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this back to the if instead of the case. arch=('amd64' 'arm64') already ensures that there will be no *) case, and this is the only place in the script where we are using a return code. I have a feeling this is what is causing the issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving up on post_remove for now. This issue needs to be looked into though

@vigress8 vigress8 closed this Dec 20, 2023
@oklopfer
Copy link
Member

oklopfer commented Dec 20, 2023

#5066
your changes were the problem. please stop unnecessarily changing variables to conform to your specific formatting standards when updating a pacscript. If only the hash and version need updating, only the hash and version need updating.

@vigress8
Copy link
Collaborator Author

I still can't figure out which exact change broke it

@vigress8 vigress8 deleted the upd/librewolf-app branch December 20, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Package Use this to request pacscript update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants