fix(mangohud): support 32bit apps #6342
Conversation
… (64bit), one for 32bit
for more information, see https://pre-commit.ci
|
ninja -j"${NCPU}" should not be necessary btw, as it should adapt according to available CPU cores automatically by default, see https://manpages.org/ninja "-j N run N jobs in parallel [default=derived from CPUs available] " |
bright-side-99
changed the title
Please keep it, because NCPU can be modified by the user if they wish. |
bright-side-99
changed the title
Thank you for your contribution. Please, do a add(lib32-mangohud) PR with a new pacscript for this one is a better idea. lib32-mangohud is very optional and users may want to install both separately. Since split package functionality is not rewritten, we need to split with lib32- prefix. Regards. |
|
I also thought about that. However I see the risk that one would not understand why mangohud is not working for certain games. |
After reflection, it's good for me. |
oklopfer
changed the title
Just to avoid miscommunication, that means youre fine with the current state, right? |
It's good to use the same pacscript for lib32. I already did once with wine-staging-git also and in this case you are right: it's better for users. Look at the review I have made. Check your package to be sure it's all good. (pacstall -IBK and you have your previews in /tmp for source, build and package). |
I do not see a review, am I missing something? Were you talking about the workflow checks? Pushed another commit that helps specifying the build directories, don't know how it got missing |
|
I also clicked on merge main, which caused the checks to be pending again, sry >.< |
|
Is there anything else left to do? Or just wait until someone has time to merge it? |
/usr/bin/mangohud build32 overwrite /usr/bin/build64 please fix this. |
okay I finally found the time to look into this. If we look at /usr/bin/mangohud, the script tries to resolve library paths like where $LIB is resolved by the dynamic linker which looks up like (ubuntu 22.04) btw. the ./build.sh build script from the mangohud repo, does also overwrite the bin I think this is fine 🤔 |
|
@bright-side-99 yes. I need to test in game. In this case it's seems to work. And it's the build method in the mangohud. Can you add theses lines to the pacscript please : Because it's a crossbuild package, his architecture have to be fixed. And his i386 package have to be provided. Still making tests these days on multilib packages and reported some issues (reported on main pacstall project). I suggest you to have a look on them if you are curious. I'm still investigating and searching solutions/alternatives. Multilib on Debian/Ubuntu is creepy and very different than archlinux. |
sure. done.
|
|
@vigress8 Good to merge |
|
What is this issue on |
Extinguished |
update script to latest specmangohud support 32bit games via 2 builds + installs, one for mangohud default (64bit) and one for 32bit
the problem with the current script is, that old games (or other 3d apps) built for 32bit are not supported by the default mangohud build. I adapted the script to build 2 mangohud versions, the default one (resulting in 64bit mangohud install) and a second one for 32bit.
Both work together nicely, I tested it by removing all mangohud from my install, then running the new script, then testing a modern game (wreckfest in my case) and an old one (WoW 3.3.5a private server ~2010 (32bit)). both work fine.
I am new to the project, so don't know about the .SRCINFO though
edit: just noticed .SRCINFO gets created automatically. neat.