Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: linux-headers-lts-6.6-deb #6619

Closed

Conversation

jimed-rand
Copy link
Contributor

Continuation of these requests (#6586)

@github-actions github-actions bot added the Package Add Use this to request a package to be added label Nov 8, 2024
@jimed-rand jimed-rand marked this pull request as draft November 8, 2024 09:46
@jimed-rand jimed-rand marked this pull request as ready for review November 13, 2024 00:29
@jimed-rand
Copy link
Contributor Author

It still got errors when I made a change. Should I close it as unplanned and re-commit with new branch or keep it be?

vigress8
vigress8 previously approved these changes Nov 13, 2024
@oklopfer
Copy link
Member

What’s with the -modular naming? It is confusing and does not match the standard of other kernels we package

@oklopfer oklopfer self-requested a review November 13, 2024 18:26
packagelist Show resolved Hide resolved
@jimed-rand
Copy link
Contributor Author

What’s with the -modular naming? It is confusing and does not match the standard of other kernels we package

modular means it's primary headers for all architecture, it's located on amd64 and if you see the sources, there's one primary headers and second headers which it's generic.

@oklopfer
Copy link
Member

oklopfer commented Nov 13, 2024

What’s with the -modular naming? It is confusing and does not match the standard of other kernels we package

modular means it's primary headers for all architecture, it's located on amd64 and if you see the sources, there's one primary headers and second headers which it's generic.

See #6619 (comment), we have a standard naming practice for these

@jimed-rand
Copy link
Contributor Author

jimed-rand commented Nov 13, 2024

What’s with the -modular naming? It is confusing and does not match the standard of other kernels we package

modular means it's primary headers for all architecture, it's located on amd64 and if you see the sources, there's one primary headers and second headers which it's generic.

See #6619 (comment), we have a standard naming practice for these

Alright, I follow what you'd mean. So, should I fix the modules and this merged commit in next commit yeah ? Or change it now ?

@oklopfer
Copy link
Member

What’s with the -modular naming? It is confusing and does not match the standard of other kernels we package

modular means it's primary headers for all architecture, it's located on amd64 and if you see the sources, there's one primary headers and second headers which it's generic.

See #6619 (comment), we have a standard naming practice for these

Alright, I follow what you'd mean. So, should I fix the modules and this merged commit in next commit yeah ? Or change it now ?

we should fix it all up now. headers also should not depend on modules, headers are always installed first. You want:

  • kernel depends on: headers headers-generic modules image-unsigned
  • image-unsigned depends on: headers headers-generic modules
  • modules depends on: headers headers-generic
  • headers-generic depends on: headers
  • headers depends on: none

@jimed-rand jimed-rand changed the title add: linux-longterm-6.6-headers-modular-deb add: linux-headers-lts-6.6-deb Nov 13, 2024
@oklopfer oklopfer closed this Nov 14, 2024
@jimed-rand jimed-rand deleted the linux-longterm-6.6-headers-modular branch November 14, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package Add Use this to request a package to be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants