-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(main): main page 작업 #153
Merged
SeolJaeHyeok
merged 18 commits into
pagers-org:team2/SeolJaeHyeok
from
SeolJaeHyeok:main
Oct 9, 2023
Merged
feat(main): main page 작업 #153
SeolJaeHyeok
merged 18 commits into
pagers-org:team2/SeolJaeHyeok
from
SeolJaeHyeok:main
Oct 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. 원래는 Pagination 컴포넌트를 패키지로 빼서 의존시켜 사용할 예정이었으나 패키지를 빌드 시켰을 때 스타일이 적용되지 않는 문제가 발생하여 일단은 같은 프로젝트 내에서 컴포넌트 생성하여 작업 -> 추후에는 결국 분리해야한다. 2. 스타일 보다는 기능에 집중하여 코드 작업
Feature/main page
아티클 상세 페이지 라우팅까지 완료
Feature/main page 2
fix: 불필요한 suspense 제거
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 이슈 링크
📖 작업 배경
🛠️ 구현 내용
💡 참고사항
next/router
가 아닌next/navigation
모듈을 사용하지 않으면 에러를 뱉어줍니다.기존
useRouter
Hook이 하는 일이 너무 많다고 생각해서 당연히 분리되어야 된다고 생각했는데 하나의 Hook에서 했던 작업을usePathname
,useSearchParams
,useRouter
로 분리해서 작성하려다 보니 코드량이 늘어나고 같은 코드를 반복하는 경우가 많아useCustomNavigate
라는 Hook을 만들어 로직을 한 공간에서 관리하려고 했습니다.근데 작성하면서도 best practice는 아닌거 같다는 생각이 들어 다른 분들은 next13에서 navigation을 어떻게 우아하게 처리하시는지 궁굼합니다!!
🖼️ 스크린샷