feat: [#174295674] Reworks the description extraction on payments (#2171

) * [#174295674] Reworks the description extraction on payments * Refactoring * [#174295674] add tests Co-authored-by: Matteo Boschi <[email protected]>
pagopa · Aug 31, 2020 · f1a4432 · f1a4432
1 parent f5c6dc0
commit f1a4432
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/ts/utils/__tests__/payment.test.ts b/ts/utils/__tests__/payment.test.ts
@@ -75,6 +75,14 @@ describe("cleanTransactionDescription", () => {
         "RFA/0123456789012/666.98/TXT/ actual description",
         "actual description"
       ],
+      [
+        "RFS/0123456789012/666.98/TXT/ actual description",
+        "actual description"
+      ],
+      [
+        "/RFS/0123456789012/666.98/TXT/ actual description",
+        "actual description"
+      ],
       ["actual description", "actual description"]
     ].forEach(([dirty, cleaned]) => {
       expect(cleanTransactionDescription(dirty)).toEqual(cleaned);

diff --git a/ts/utils/payment.ts b/ts/utils/payment.ts
@@ -109,15 +109,19 @@ export function walletHasFavoriteAvailablePsp(
   return walletPspInPsps !== undefined;
 }
 
+/**
+ * This tags are defined in PagoPA specs for transaction description.
+ * @see https://pagopa-codici.readthedocs.io/it/latest/_docs/Capitolo3.html
+ */
+const prefixes: ReadonlyArray<string> = ["RFA", "RFB", "RFS"];
+
 const hasDescriptionPrefix = (description: string) =>
-  description.startsWith("/RFA/") ||
-  description.startsWith("/RFB/") ||
-  description.startsWith("RFA/") ||
-  description.startsWith("RFB/");
+  prefixes.some(
+    p => description.startsWith(`${p}/`) || description.startsWith(`/${p}/`)
+  );
 
 /**
  * This function removes the tag from payment description of a PagoPA transaction.
- * @see https://pagopa-codici.readthedocs.io/it/latest/_docs/Capitolo3.html
  */
 export const cleanTransactionDescription = (description: string): string => {
   // detect description in pagoPA format - note that we also check for cases