-
Notifications
You must be signed in to change notification settings - Fork 113
chore: [IOAPPX-463] Enable full support for edge-to-edge navigation on Android #6602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6602 +/- ##
==========================================
- Coverage 59.68% 59.66% -0.02%
==========================================
Files 1849 1849
Lines 40114 40135 +21
Branches 9283 9237 -46
==========================================
+ Hits 23942 23947 +5
- Misses 16100 16115 +15
- Partials 72 73 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Short description
This PR enables full support for edge-to-edge navigation on Android.
List of changes proposed in this pull request
MainActivity.ktfileBarcodeScanScreenServiceDetailscreenreact-native-safe-area-contextto the latest versionClose button overlaps status bar when Help Centre is openToast notifications overlap the status baredge to edgeenabled io-app-design-system#492Bottom margins (with or without CTA) are too narrowIdentificationModalWhen the button mode is enabled, the navigation bar will have an opaque black background instead of the light grey background it had before.Important
These issues appear to be caused by the
react-native-safe-area-contextpackage not handling the insets properly:Preview
Splash screen
Before
After
Barcode Scan
Service Detail
Related tech docs
How to test