Skip to content

Conversation

@RiccardoMolinari95
Copy link
Collaborator

@RiccardoMolinari95 RiccardoMolinari95 commented Nov 3, 2025

Short description

This PR adds tracking events related to the eID reissuing flow.

List of changes proposed in this pull request

  • Sends the ITW_REISSUING_EID_MANDATORY event when attempting to obtain a credential with an expired eID.
  • Introduces useItwEidLifecycleAlertTracking for tracking the eID lifecycle banner, capturing both the alert view and tap events to start the reissuing process.
  • Handles cases where banner tracking should be skipped: when opening the eID BottomSheet or when the credential is a PID (IT Wallet enabled).

How to test

Verify that all tracking events are correctly sent:

  1. Attempt to obtain a credential with an expired eID and confirm that the ITW_REISSUING_EID_MANDATORY event is fired.
  2. With an expired eID, display the eID lifecycle alert and confirm that BANNER event is sent.
  3. Tap the eID lifecycle alert and confirm that the BANNER_TAP event is sent.
  4. Open the eID BottomSheet and confirm that the BANNER event is not sent, but tapping the lifecycle alert still sends the BANNER_TAP event.
  5. With a PID confirm that no banner tracking events are sent, opening the PID details

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 65.21739% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.67%. Comparing base (8868bf0) to head (ed2c291).

Files with missing lines Patch % Lines
...et/common/hooks/useItwEidLifecycleAlertTracking.ts 73.52% 8 Missing and 1 partial ⚠️
...ns/ItwPresentationEidVerificationExpiredScreen.tsx 0.00% 3 Missing ⚠️
ts/features/itwallet/analytics/index.ts 33.33% 2 Missing ⚠️
...twallet/common/components/ItwEidLifecycleAlert.tsx 66.66% 1 Missing ⚠️
...omponents/ItwPresentationCredentialStatusAlert.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7572   +/-   ##
=======================================
  Coverage   59.66%   59.67%           
=======================================
  Files        1859     1860    +1     
  Lines       40312    40357   +45     
  Branches     9318     9334   +16     
=======================================
+ Hits        24053    24083   +30     
- Misses      16187    16188    +1     
- Partials       72       86   +14     
Files with missing lines Coverage Δ
...common/components/ItwEidInfoBottomSheetContent.tsx 70.37% <ø> (ø)
...llet/wallet/components/ItwWalletCardsContainer.tsx 92.00% <100.00%> (+0.33%) ⬆️
...twallet/common/components/ItwEidLifecycleAlert.tsx 82.75% <66.66%> (-1.86%) ⬇️
...omponents/ItwPresentationCredentialStatusAlert.tsx 77.06% <50.00%> (+0.21%) ⬆️
ts/features/itwallet/analytics/index.ts 40.11% <33.33%> (-0.07%) ⬇️
...ns/ItwPresentationEidVerificationExpiredScreen.tsx 7.69% <0.00%> (-2.31%) ⬇️
...et/common/hooks/useItwEidLifecycleAlertTracking.ts 73.52% <73.52%> (ø)

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8868bf0...ed2c291. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RiccardoMolinari95 RiccardoMolinari95 marked this pull request as ready for review November 3, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants