Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [SIW-2197] Make idphint parameter optional for auth request url #212

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Apr 1, 2025

List of Changes

  • made the idpHint parameter in the buildAuthorizationUrl function optional by updating its type definition and usage.
  • added tests for buildAuthorizationUrl function

Motivation and Context

To obtain an L3 PID, the idphint parameter must be omitted from the authentication request URL.
This pull request updates the buildAuthorizationUrl function to make the idpHint parameter optional, allowing authentication requests to be generated without explicitly setting an IdP hint when necessary.

How Has This Been Tested?

Unit tests

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mastro993 mastro993 self-assigned this Apr 1, 2025
@mastro993 mastro993 requested a review from a team as a code owner April 1, 2025 12:29
@mastro993 mastro993 requested review from grausof and manuraf April 1, 2025 12:29
@mastro993 mastro993 changed the title [SIW-2197] Make idphint parameter optional for auth request url chore: [SIW-2197] Make idphint parameter optional for auth request url Apr 1, 2025
@github-actions github-actions bot added the chore label Apr 1, 2025
Copy link
Contributor

@grausof grausof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mastro993 mastro993 merged commit acdb474 into master Apr 2, 2025
6 checks passed
@mastro993 mastro993 deleted the SIW-2197-optional-idphint-parameter-for-auth-url branch April 2, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants