Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: P4ADEV-1774 save debt position #11

Merged
merged 17 commits into from
Jan 14, 2025
Merged

feat: P4ADEV-1774 save debt position #11

merged 17 commits into from
Jan 14, 2025

Conversation

RiccardoGiuliani
Copy link
Collaborator

Description

List of Changes

Motivation and Context

How Has This Been Tested?

  • Pre-Deploy Test
    • Unit
    • Integration (Narrow)
  • Post-Deploy Test
    • Isolated Microservice
    • Broader Integration
    • Acceptance
    • Performance & Load

Types of changes

  • PATCH - Bug fix (backwards compatible bug fixes)
  • MINOR - New feature (add functionality in a backwards compatible manner)
  • MAJOR - Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CHORE - Minor Change (fix or feature that don't impact the functionality e.g. Documentation or lint configuration)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@RiccardoGiuliani RiccardoGiuliani marked this pull request as ready for review January 9, 2025 09:29
antonioT90
antonioT90 requested changes Jan 10, 2025
View reviewed changes
src/main/java/it/gov/pagopa/pu/debtpositions/util/Repositories.java Outdated Show resolved Hide resolved
src/test/java/it/gov/pagopa/pu/debtpositions/mapper/DebtPositionMapperTest.java Outdated Show resolved Hide resolved
src/test/java/it/gov/pagopa/pu/debtpositions/mapper/InstallmentMapperTest.java Show resolved Hide resolved
src/test/java/it/gov/pagopa/pu/debtpositions/mapper/PaymentOptionMapperTest.java Outdated Show resolved Hide resolved
src/test/java/it/gov/pagopa/pu/debtpositions/mapper/PersonMapperTest.java Show resolved Hide resolved
src/test/java/it/gov/pagopa/pu/debtpositions/mapper/TransferMapperTest.java Show resolved Hide resolved
src/test/java/it/gov/pagopa/pu/debtpositions/service/DebtPositionServiceImplTest.java Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@RiccardoGiuliani RiccardoGiuliani merged commit 314c933 into develop Jan 14, 2025
11 checks passed
@RiccardoGiuliani RiccardoGiuliani deleted the P4ADEV-1774_saveDebtPosition branch January 14, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonioT90 antonioT90 antonioT90 approved these changes

@antocalo antocalo Awaiting requested review from antocalo antocalo is a code owner

@Benedetta-fabbri Benedetta-fabbri Awaiting requested review from Benedetta-fabbri Benedetta-fabbri is a code owner

@LarissaASLeite LarissaASLeite Awaiting requested review from LarissaASLeite LarissaASLeite is a code owner

@oleksiybozhykntt oleksiybozhykntt Awaiting requested review from oleksiybozhykntt oleksiybozhykntt is a code owner

@ElisKina-dev ElisKina-dev Awaiting requested review from ElisKina-dev ElisKina-dev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RiccardoGiuliani @antonioT90