generated from pagopa/template-java-spring-microservice
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHK-1565] feat(tracing): propagate tracing information when enqueueing events #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovanniberti
force-pushed
the
queue-tracing
branch
from
July 12, 2023 15:13
a3e1b52
to
29739bc
Compare
pietro-tota
reviewed
Jul 13, 2023
...in/it/pagopa/ecommerce/transactions/scheduler/publishers/TransactionExpiredEventPublisher.kt
Outdated
Show resolved
Hide resolved
ping :) |
giovanniberti
force-pushed
the
queue-tracing
branch
from
July 19, 2023 12:39
811ebba
to
fc100cb
Compare
🎉 All dependencies have been resolved ! |
pietro-tota
previously approved these changes
Jul 25, 2023
giovanniberti
force-pushed
the
queue-tracing
branch
from
July 26, 2023 08:29
db02ba1
to
83a9849
Compare
giovanniberti
force-pushed
the
queue-tracing
branch
2 times, most recently
from
July 26, 2023 08:32
c402b71
to
a6f44ac
Compare
giovanniberti
force-pushed
the
queue-tracing
branch
from
July 26, 2023 08:33
a6f44ac
to
0641575
Compare
Kudos, SonarCloud Quality Gate passed! |
pietro-tota
reviewed
Aug 3, 2023
pietro-tota
previously approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done. Add a brief description
Co-authored-by: Pietro Tota <[email protected]>
pietro-tota
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Motivation and Context
This PRs uses the new queue event data structure to propagate tracing information across producer (in this case this service) and consumers (event-dispatcher).
This allows ELK to correlate the two endpoints and makes monitoring more efficient.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
expected)
Checklist:
Depends on #60
Depends on pagopa/pagopa-ecommerce-commons#94