Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHK-1565] feat(tracing): propagate tracing information when enqueueing events #59

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

giovanniberti
Copy link
Contributor

@giovanniberti giovanniberti commented Jul 12, 2023

List of Changes

  • propagate tracing information when enqueueing events

Motivation and Context

This PRs uses the new queue event data structure to propagate tracing information across producer (in this case this service) and consumers (event-dispatcher).
This allows ELK to correlate the two endpoints and makes monitoring more efficient.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Depends on #60
Depends on pagopa/pagopa-ecommerce-commons#94

@giovanniberti giovanniberti marked this pull request as ready for review July 12, 2023 15:18
@giovanniberti giovanniberti requested a review from a team as a code owner July 12, 2023 15:18
@pietro-tota
Copy link
Contributor

ping :)

@dpulls
Copy link

dpulls bot commented Jul 19, 2023

🎉 All dependencies have been resolved !

pietro-tota
pietro-tota previously approved these changes Jul 25, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@giovanniberti giovanniberti requested a review from a team July 26, 2023 12:30
pom.xml Outdated Show resolved Hide resolved
pietro-tota
pietro-tota previously approved these changes Aug 3, 2023
Copy link
Contributor

@pietro-tota pietro-tota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Add a brief description

@giovanniberti giovanniberti merged commit 878ec0a into main Aug 3, 2023
@giovanniberti giovanniberti deleted the queue-tracing branch August 3, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants