Skip to content

Feature/pin 7481 create purpose template step1 modal #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 3, 2025
Merged

Feature/pin 7481 create purpose template step1 modal #1406

merged 17 commits into from
Nov 3, 2025

Conversation

@martinaCampoli
Copy link
Contributor

@martinaCampoli martinaCampoli commented Sep 3, 2025 •
edited by Alepazz
Loading

Issue

UI
PIN-7481
API CALL
PIN-7846

Context / Why

  • Added a dialog to select the tenant kind when creating a new purpose template.
  • Added useGetSidenavItems tests for new sidenav sections
  • Added tests for purpose templates list page
  • Added tests for DialogTenantKindPurposeTemplate
  • Added create new purpose template API call.
image

@martinaCampoli martinaCampoli changed the base branch from dev to feature/PIN-7480-purpose-template-list-page September 3, 2025 12:54
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7480-purpose-template-list-page branch from c688aeb to f285086 Compare September 9, 2025 09:53
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7481-create-purpose-template-step1-modal branch from d5dd1da to ee5b841 Compare September 9, 2025 09:53
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7480-purpose-template-list-page branch from 6ff27b5 to 64f3f60 Compare September 9, 2025 14:08
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7481-create-purpose-template-step1-modal branch from dfe82b0 to c872f9f Compare September 9, 2025 14:09
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7480-purpose-template-list-page branch from 64f3f60 to 50b4d64 Compare September 9, 2025 15:37
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7481-create-purpose-template-step1-modal branch from bb42b91 to 6696c1e Compare September 9, 2025 15:38
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7480-purpose-template-list-page branch from 50b4d64 to 7255d39 Compare September 11, 2025 09:21
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7481-create-purpose-template-step1-modal branch from 9cbbae1 to 1f43e4c Compare September 11, 2025 09:21
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7480-purpose-template-list-page branch from 7255d39 to ce88873 Compare September 15, 2025 08:03
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7481-create-purpose-template-step1-modal branch from 54107d1 to dd93bb3 Compare September 15, 2025 08:05
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7480-purpose-template-list-page branch from ce88873 to 2174a87 Compare September 16, 2025 08:25
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7481-create-purpose-template-step1-modal branch from dd93bb3 to 6d54fee Compare September 16, 2025 08:25
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7480-purpose-template-list-page branch from 2174a87 to 88735f0 Compare September 18, 2025 13:57
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7481-create-purpose-template-step1-modal branch from 6d54fee to 8cc0867 Compare September 18, 2025 13:58
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7480-purpose-template-list-page branch from 88735f0 to a906cc6 Compare September 19, 2025 14:45
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7481-create-purpose-template-step1-modal branch from 0f1f230 to df38047 Compare September 19, 2025 14:45
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7480-purpose-template-list-page branch from a906cc6 to 2696a1b Compare September 23, 2025 09:40
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7481-create-purpose-template-step1-modal branch from df38047 to f511f8c Compare September 23, 2025 09:40
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7480-purpose-template-list-page branch from 2696a1b to a8c67f1 Compare September 24, 2025 15:28
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7481-create-purpose-template-step1-modal branch from f511f8c to bce57f5 Compare September 24, 2025 15:28
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7480-purpose-template-list-page branch from a8c67f1 to b34b00c Compare October 1, 2025 15:46
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7481-create-purpose-template-step1-modal branch from bce57f5 to b2a2f38 Compare October 1, 2025 15:46
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7480-purpose-template-list-page branch from b34b00c to db95c69 Compare October 9, 2025 14:24
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7481-create-purpose-template-step1-modal branch from b2a2f38 to d5764b1 Compare October 9, 2025 15:35
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7480-purpose-template-list-page branch from 863030f to 3b906d6 Compare October 10, 2025 09:06
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7481-create-purpose-template-step1-modal branch from 4d5247e to 65c41a9 Compare October 10, 2025 09:06
@Alepazz Alepazz requested a review from borgesis95 October 22, 2025 12:41
@Alepazz Alepazz marked this pull request as ready for review October 22, 2025 12:41
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7481-create-purpose-template-step1-modal branch from 2a93a29 to aa6bd9f Compare October 22, 2025 15:47
borgesis95
borgesis95 reviewed Oct 23, 2025
View reviewed changes
Copy link
Contributor

@borgesis95 borgesis95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test is failing here

borgesis95
borgesis95 reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

@borgesis95 borgesis95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for me, could improve code coverage here?for instance, this new component hasn't been tested EServiceTemplateCreateStepPurposeAddPurposeTable.tsx

@martinaCampoli
Copy link
Contributor Author

martinaCampoli commented Oct 28, 2025

good for me, could improve code coverage here?for instance, this new component hasn't been tested EServiceTemplateCreateStepPurposeAddPurposeTable.tsx

Component comes from the Eservice template feature — should it be tested in this PR?

@martinaCampoli martinaCampoli force-pushed the feature/PIN-7481-create-purpose-template-step1-modal branch from 9f822e3 to 7cdc157 Compare October 28, 2025 13:34
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7480-purpose-template-list-page branch from 7003372 to dc329fc Compare October 28, 2025 13:43
martinaCampoli and others added 16 commits October 28, 2025 14:44
@martinaCampoli
Added DialogTenantKindPurposeTemplate to create purpose template
fb7a861
@martinaCampoli
Added purpose tempalate dialog to dialog.types
6b37a7f
@martinaCampoli
Removed console.log
e879ad2
@martinaCampoli
Fixed routes + commented not available routes
e6f54d9
@martinaCampoli
Added useGetSidenavItems tests for new sections
c77b6ab
@martinaCampoli
Added tests for purpose templates list page and for dialog + Fixed di…
90db15d 
…alog type in eservice template test
@martinaCampoli
Fixed types after rebase
f10e408
@martinaCampoli
Added Radio button for personal data
6a68259
@martinaCampoli
Fixed tests replaced with rebase
5456aaf
@martinaCampoli
Removed isConsumerDelegable from api call for eservice options
d3c7f58
@Alepazz @martinaCampoli
fix: Changed name to filename in generateApi props to specify generat…
ab89fa4 
…ed type destination file name (PIN-7846)
@Alepazz @martinaCampoli
feature: Added post create purpose template api call (PIN-7846)
6c1b8e0
@Alepazz @martinaCampoli
fix: Rollback generated file formatting and name property (PIN-7846)
2f0c17c
@Alepazz @martinaCampoli
feature: Added personalData support on purposeTemplate creation (PIN-…
284d18c 
…7846)
@Alepazz @martinaCampoli
fix: Removed logs (PIN-7846)
5de43e8
@martinaCampoli
Updated types and commented out handlesPersonalData
70b3cc6
@martinaCampoli martinaCampoli force-pushed the feature/PIN-7481-create-purpose-template-step1-modal branch from 7cdc157 to 70b3cc6 Compare October 28, 2025 13:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 28, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
78.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Alepazz Alepazz merged commit 71acf5d into feature/PIN-7480-purpose-template-list-page Nov 3, 2025
5 of 6 checks passed
@Alepazz Alepazz deleted the feature/PIN-7481-create-purpose-template-step1-modal branch November 3, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@borgesis95 borgesis95 borgesis95 approved these changes

@ruggerocastagnola ruggerocastagnola Awaiting requested review from ruggerocastagnola

@Carminepo2 Carminepo2 Awaiting requested review from Carminepo2

Assignees

No one assigned

Labels

purpose-template

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martinaCampoli @borgesis95 @Alepazz