Feature/pin 7581 7860 add personal data field create and summary page #1440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinaCampoli
force-pushed
the
feature/PIN-7581-add-personal-data-field-create-and-summary-page
branch
2 times, most recently
from
76ec053 to
975adc1
Compare
martinaCampoli
force-pushed
the
feature/PIN-7315-guideline-adaptation
branch
from
cbb5f08 to
2811a0f
Compare
martinaCampoli
force-pushed
the
feature/PIN-7581-add-personal-data-field-create-and-summary-page
branch
5 times, most recently
from
3bc5bc3 to
d86da1f
Compare
martinaCampoli
requested review from
Carminepo2,
borgesis95 and
ruggerocastagnola
as code owners
martinaCampoli
force-pushed
the
feature/PIN-7581-add-personal-data-field-create-and-summary-page
branch
2 times, most recently
from
8a420e7 to
1273f49
Compare
martinaCampoli
changed the title
martinaCampoli
force-pushed
the
feature/PIN-7581-add-personal-data-field-create-and-summary-page
branch
2 times, most recently
from
aa1eafa to
96fad36
Compare
borgesis95
reviewed
Oct 21, 2025
| sx={{ mb: 0, mt: 3 }} | ||
| onValueChange={(mode) => onEserviceModeChange!(mode as EServiceMode)} | ||
| /> | ||
| {FEATURE_FLAG_ESERVICE_PERSONAL_DATA === 'true' && ( |
Contributor
There was a problem hiding this comment.
Why are you check if is true comparing it with a string?
In order to have a boolean value you can add (on env.ts file)
FEATURE_FLAG_ESERVICE_PERSONAL_DATA: z.enum(['true', 'false']).default('false').transform((value) => value === "true")
src/pages/ProviderEServiceSummaryPage/components/ProviderEServiceGeneralInfoSummary.tsx
Outdated
Show resolved
Hide resolved
...roviderEServiceCreatePage/components/EServiceCreateStepGeneral/EServiceCreateStepGeneral.tsx
Show resolved
Hide resolved
...eStepPurpose/EServiceCreateStepPurposeRiskAnalysis/EServiceCreateStepPurposeRiskAnalysis.tsx
Outdated
Show resolved
Hide resolved
src/pages/ProviderEServiceSummaryPage/ProviderEServiceSummary.page.tsx
Outdated
Show resolved
Hide resolved
martinaCampoli
force-pushed
the
feature/PIN-7581-add-personal-data-field-create-and-summary-page
branch
from
9b2e0a9 to
86ba408
Compare
borgesis95
approved these changes
Oct 22, 2025
martinaCampoli
force-pushed
the
feature/PIN-7581-add-personal-data-field-create-and-summary-page
branch
from
eeee60f to
177af25
Compare
|
martinaCampoli
merged commit 02167d5
into
feature/PIN-7315-guideline-adaptation
5 of 6 checks passed
martinaCampoli
deleted the
feature/PIN-7581-add-personal-data-field-create-and-summary-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.