-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX GRAMMATICAL ERROR #1
base: master
Are you sure you want to change the base?
Conversation
it should be `0 seconds` not `0 second` i cannot believe you did this ❗ ❗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! Thanks for your contribution!
what if there's a negative value somehow? then it would be -1 seconds? that seems odd to me |
You didn't even add a test case to prevent this issue in the future |
@aidenwallis Actually I'll retract my approval for now - could you provide a test case in which this case errors out? This should be pretty well-tested already to never print zero values https://github.com/pajbot/utils/blob/master/time_test.go#L59-L77 |
eh |
hi :) randomly chose to come back |
🎃 |
…m so quirky and original xD
🐛 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be
0 seconds
not0 second
i cannot believe you did this ❗ ❗