Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should post lgtm #10

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

should post lgtm #10

wants to merge 6 commits into from

Conversation

pajlada
Copy link
Owner

@pajlada pajlada commented Aug 20, 2022

No description provided.

@github-actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/main.cpp Outdated

void anotherFunction()
{
auto test = new std::string; // :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'auto test' can be declared as 'auto *test' [llvm-qualified-auto]

Suggested change
auto test = new std::string; // :)
auto *test = new std::string; // :)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions


void anotherFunction()
{
auto test = new std::string; // :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'auto test' can be declared as 'auto *test' [llvm-qualified-auto]

Suggested change
auto test = new std::string; // :)
auto *test = new std::string; // :)

void anotherFunction()
{
auto test = new std::string; // :)
auto test2 = new std::string; // :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'auto test2' can be declared as 'auto *test2' [llvm-qualified-auto]

Suggested change
auto test2 = new std::string; // :)
auto *test2 = new std::string; // :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant