Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add collection item rarity when monster related #427

Merged
merged 5 commits into from
Mar 3, 2024

Conversation

iProdigy
Copy link
Member

Follow-up to #425; work towards #139

image

@iProdigy iProdigy marked this pull request as ready for review February 20, 2024 20:45
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested in-game, but looks good

@iProdigy
Copy link
Member Author

iProdigy commented Mar 3, 2024

works as expected in-game

image

image

however this reveals we need to boost the kill count reported by loot tracker based on rate of Nothing drop; the true kc is 20+ since nothing drops about half the time for f2p flesh crawlers (but this problem spans both collection/loot, so will be tackled in a separate PR)

@iProdigy iProdigy merged commit 9b9502e into pajlads:master Mar 3, 2024
4 checks passed
@iProdigy iProdigy deleted the feature/collection-rarity-npc branch March 3, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants