feat: include rarity and luck in pet notifications #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
approved these changes
Mar 17, 2024
| "Vorki", | ||
| "Wisp", | ||
| "Youngllef" | ||
| PET_NAMES_TO_SOURCE = Map.<String, Source>ofEntries( |
pajlada
reviewed
Mar 17, 2024
iProdigy
commented
Mar 22, 2024
pajlada
approved these changes
Mar 23, 2024
|
for the rarity calculation, we also need extra scrutiny on the skilling pets Baby chinchompa: is assuming black chins reasonable |
|
I think all of those assumptions are reasonable, and we can change that around if someone else thinks they're completely off. |
iProdigy
commented
Mar 30, 2024
|
|
pajlada
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes pet component of #139