Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): allow matching on runelite notifications #493

Merged
merged 8 commits into from
Jun 15, 2024

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Jun 8, 2024

Similar to #489 but for NotificationFired

@iProdigy
Copy link
Member Author

iProdigy commented Jun 8, 2024

also resolves one ❌ for dink in #461

@iProdigy
Copy link
Member Author

✅ tested in-game

image

{
  "type": "CHAT",
  "playerName": "dankgg",
  "accountType": "NORMAL",
  "dinkAccountHash": "172d48fcbfce074e5385d67760091497dd5a761d97d19e871586ec54",
  "content": "dankgg received a chat notification:\n\n```\nNPC aggression has expired!\n```",
  "seasonalWorld": false,
  "world": 393,
  "regionId": 12698,
  "extra": {
    "type": "UNKNOWN",
    "source": "NotificationFired",
    "message": "NPC aggression has expired!"
  }
}

@iProdigy iProdigy merged commit 9d51ca9 into pajlads:master Jun 15, 2024
4 checks passed
@iProdigy iProdigy deleted the feature/chat-read-notifications branch June 15, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants