Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(loot): add config to require both rarity and value to notify #499

Merged
merged 11 commits into from
Jul 20, 2024
Merged

feat(loot): add config to require both rarity and value to notify #499

merged 11 commits into from
Jul 20, 2024

Commits on Jul 4, 2024

  1. feat(loot): add config to require both rarity and value to notify

    @iProdigy
    iProdigy committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    9fedcb6 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. chore: update changelog

    @iProdigy
    iProdigy authored Jul 5, 2024
    Configuration menu
    Copy the full SHA
    d5da78c View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. add test ensuring loot notification doesn't fire when 

    lootRarityValueIntersection is enabled

it matches rarity threshold, but not loot value threshold
    @pajlada
    pajlada committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    78b8c5c View commit details
    Browse the repository at this point in the history

  2. add test ensuring loot notification doesn't fire when 

    lootRarityValueIntersection is enabled and loot is too common
    @pajlada
    pajlada committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    ac1e1b4 View commit details
    Browse the repository at this point in the history

  3. add test ensuring it fires

    @pajlada
    pajlada committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    77f740b View commit details
    Browse the repository at this point in the history

  4. chore: fix test case

    @iProdigy
    iProdigy committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    ed0b9b7 View commit details
    Browse the repository at this point in the history

  5. chore: rename a couple tests

    @iProdigy
    iProdigy committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    d05dd63 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into feature/loot-rarity-value-intersection

    @iProdigy
    iProdigy authored Jul 13, 2024
    Configuration menu
    Copy the full SHA
    27d270b View commit details
    Browse the repository at this point in the history

  7. refactor: simplify implementation

    @iProdigy
    iProdigy committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    21bb111 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. Merge branch 'master' into feature/loot-rarity-value-intersection

    @iProdigy
    iProdigy authored Jul 14, 2024
    Configuration menu
    Copy the full SHA
    d35764a View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Merge branch 'master' into feature/loot-rarity-value-intersection

    @iProdigy
    iProdigy authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    aed80e2 View commit details
    Browse the repository at this point in the history