Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear particular notifier state when disabled #515

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Aug 5, 2024

avoids outdated notification data if players are disabling and enabling notifiers (while plugin remains enabled)

for example: disable level notifier, gain a level, later enable level notifier, get single xp drop for same skill => previously dink would trigger a level notif (tho level up occurred much earlier)

@iProdigy
Copy link
Member Author

✅ tested in-game

@iProdigy iProdigy enabled auto-merge (squash) August 13, 2024 02:27
@iProdigy iProdigy merged commit 538efa1 into pajlads:master Aug 13, 2024
4 checks passed
@iProdigy iProdigy deleted the fix/stale-state branch August 13, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants