feat: add DinkMigrate client command #564
Conversation
There was a problem hiding this comment.
The readme is clear & the code looks good to me. Should be a fairly simple review - builder pattern looks good for both the small & big plugins.
Just one question regarding the message after a migration, then I'm good
I have not tested this yet, which we should do somewhat thoroughly before merging this in (+ making sure maintainers have a chance to look at the issues you've created)
| plugin.addChatSuccess("Finished migrating configs from other plugins. " + | ||
| "Please verify the latest Dink settings and disable your other webhook plugins"); |
There was a problem hiding this comment.
Should we mention that you need to re-open config panel for changes to be reflected?
There was a problem hiding this comment.
Please close and open the plugin settings panel for these changes to be visually reflected. should already be in chat from the handleImport call, but we could reiterate it since ppl struggle to read
Closes #563
PJGJ210/Discord-Collection-Logger#5 ✅
Boredska/gim-bank-discord#3
MidgetJake/UniversalDiscordNotifier#41
jamesdrudolph/Discord-Death-Notifications#11
RinZJ/better-discord-loot-logger#30
ATremonte/Discord-Level-Notifications#12
jack0lantern/raidshamer#2 ✅