Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to parse java.version from pom.xml #218

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

c0d1ngm0nk3y
Copy link

@c0d1ngm0nk3y c0d1ngm0nk3y commented Dec 9, 2022

see #217

Summary

If a pom.xml is found, it is parsed and checked for the java.version property (spring boot). If the property is found, this information is used to not only require a JDK, but a JDK of the correct version.

Use Cases

If a spring boot application is requiring a specific java version (e.g. 17) which is different from the default one being installed, the user is not forced to provide BP_JVM_VERSION , but the version is auto detected.

Note: This would need a change for libjvm to honor the required metadata.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@c0d1ngm0nk3y c0d1ngm0nk3y requested a review from a team December 9, 2022 12:08
@c0d1ngm0nk3y c0d1ngm0nk3y marked this pull request as draft December 9, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant