Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use time difference instead of period for cmd_dt #50

Open
wants to merge 1 commit into
base: hydro-devel
Choose a base branch
from
Open

Use time difference instead of period for cmd_dt #50

wants to merge 1 commit into from

Conversation

efernandez
Copy link

This makes the limiters more robust under RT issue, since we compute the actual time difference instead of using period. Therefore, this relax the RT constraints.

Tested on gazebo.
Testing on a robot still pending.

@bmagyar
Copy link
Member

bmagyar commented Jan 16, 2015

Seems to be ok. Let me know how the testing on the robot goes. (Maybe even show it before/after)

@adolfo-rt
Copy link

What is the RT issue?.

Consider that if the system clock jumps discretely during controller operation unexpected things will happen. cmd_dt could be very large or even negative.

@efernandez
Copy link
Author

@adolfo-rt If that's the case, we shouldn't use the period also for the odometry computations (now we use the time difference for computing the twist if dt > 0.0001 because there's a division), right?
@bmagyar has remembered me that using the period for the odometry computations didn't give good results.

@adolfo-rt
Copy link

@adolfo-rt If that's the case, we shouldn't use the period also for the odometry computations (now we use the time difference for computing the twist if dt > 0.0001 because there's a division), right?

If odometry uses time differences, then it is also subject to the same issues when the clock changes discretely.

I still don't know what is the RT issue. Is there significant jitter in period values?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants