-
Notifications
You must be signed in to change notification settings - Fork 16
Document versions.props comment format #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Generate changelog in
|
void ignores_comment_on_same_line_with_no_hash() throws IOException { | ||
Path propsFile = tempDir.resolve("versions.props"); | ||
Files.writeString( | ||
propsFile, "com.palantir.test:test = 1.0.0 comment on same line with no hash", StandardCharsets.UTF_8); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems less than ideal, but I'm not sure we gain much by making this invalid
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
Still valuable but only P3 |
Before this PR
Expected
versions.props
comment format is not documented: https://github.com/palantir/gradle-consistent-versions?tab=readme-ov-file#versionsprops-lower-bounds-for-dependenciesAfter this PR
==COMMIT_MSG==
Document current
versions.props
comment format==COMMIT_MSG==
This also adds test coverage for the documented comment formats, plus some other comment behaviors that currently exist. I'm not sure the test case in
ignores_comment_on_same_line_with_no_hash()
is ideal, but supporting that behavior doesn't seem to be hurting much.Possible downsides?
None known