Skip to content

Conversation

ash211
Copy link
Contributor

@ash211 ash211 commented Feb 13, 2024

Before this PR

Expected versions.props comment format is not documented: https://github.com/palantir/gradle-consistent-versions?tab=readme-ov-file#versionsprops-lower-bounds-for-dependencies

After this PR

==COMMIT_MSG==
Document current versions.props comment format
==COMMIT_MSG==

This also adds test coverage for the documented comment formats, plus some other comment behaviors that currently exist. I'm not sure the test case in ignores_comment_on_same_line_with_no_hash() is ideal, but supporting that behavior doesn't seem to be hurting much.

Possible downsides?

None known

@changelog-app
Copy link

changelog-app bot commented Feb 13, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Document current versions.props comment format

Check the box to generate changelog(s)

  • Generate changelog entry

@ash211 ash211 changed the title Add more tests for current VersionsProps behavior Document current versions.props comment format Feb 13, 2024
@ash211 ash211 changed the title Document current versions.props comment format Document versions.props comment format Feb 13, 2024
void ignores_comment_on_same_line_with_no_hash() throws IOException {
Path propsFile = tempDir.resolve("versions.props");
Files.writeString(
propsFile, "com.palantir.test:test = 1.0.0 comment on same line with no hash", StandardCharsets.UTF_8);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems less than ideal, but I'm not sure we gain much by making this invalid

@ash211 ash211 requested a review from CRogers February 7, 2025 06:35
Copy link

stale bot commented Jun 27, 2025

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

@stale stale bot added the stale label Jun 27, 2025
@ash211
Copy link
Contributor Author

ash211 commented Jul 7, 2025

Still valuable but only P3

@ash211 ash211 removed the stale label Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants