Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support aarch64 #469

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Support aarch64 #469

wants to merge 2 commits into from

Conversation

pariser
Copy link

@pariser pariser commented Mar 22, 2022

Before this PR

Addresses #468 -- plugin not respecting arm64 architectures

After this PR

==COMMIT_MSG==
Support downloading of aarch64 builds of graal
==COMMIT_MSG==

Possible downsides?

Users of aarch64 may now receive aarch64 graal builds instead of amd64 builds, which may cause issues, though presumably graal team have identified and fixed said issues before releasing builds targeting aarch64.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/gradle-graal, @pariser! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@changelog-app
Copy link

changelog-app bot commented Mar 22, 2022

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Support downloading of aarch64 builds of graal

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from tetigi March 22, 2022 18:02
@stale
Copy link

stale bot commented Apr 27, 2022

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

@stale stale bot added the stale label Apr 27, 2022
@tpetracca tpetracca requested review from carterkozak and removed request for tetigi April 28, 2022 16:12
@stale stale bot removed the stale label Apr 28, 2022
@0xE282B0
Copy link

@pariser, @carterkozak, can this PR be reactivated?

@Spikhalskiy
Copy link

Spikhalskiy commented Aug 18, 2022

@carterkozak @tpetracca any chance this PR can actually be merged? Apple Silicone support in 22.2.0 is a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants