feat: Add validate command #1114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an implementation of adding validate command to policybot. This will implement palantir#862. FOr now it is a bit rough but if this is the way we want to go we can make it a big nicer. It copies we way how validate is handled as a request. Signed-off-by: Atze de Vries <[email protected]>
Generate changelog in
|
pravindahal
reviewed
Nov 24, 2025
Co-authored-by: Pravin Dahal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of adding validate command to policybot. This will implement #862.
FOr now it is a bit rough but if this is the way we want to go we can make it a big nicer. It copies we way how validate is handled as a request.
Before this PR
Validations of policy required access to a running policybot server. Running a server requires a github applicaton or a mock of a github application.
After this PR
A user can run
policy-bot validate -p < path to policy file>. This is useful if you want to run it in CI.Possible downsides?
It adds a little bit of code to maintain i guess.