Port build system to meson and clean up directories #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustSoup312
changed the title
| dependencies : [newlib], | ||
| include_directories : inc, | ||
| c_args : [ | ||
| '-Os', |
There was a problem hiding this comment.
You can set project default_option to optimization=s
| '--target=arm64-apple-ios12.0', | ||
| '-std=gnu17', | ||
| '-moutline', | ||
| '-flto', |
| c_args : [ | ||
| '-Os', | ||
| '--target=arm64-apple-ios12.0', | ||
| '-std=gnu17', |
|
modifying the source tree structure would make it difficult to merge checkra1n/PongoOS, also the bootm command is in checkra1n/PongoOS iOS15 branch already |
klokik
reviewed
Feb 27, 2025
| @@ -0,0 +1,4 @@ | |||
| pongo_drivers_recfg_sources_c = [ | |||
| 'src/pongo/drivers/recfg/recfg.c', | |||
There was a problem hiding this comment.
Consider using files() function and skipping the initial directory path component within the sources list.
Renaming and moving directories around would be so much easier by not having to change all the build files in a subtree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meson has a lot of nice-to-haves that make doesn't. It's like a chisel to a hammer. Porting the build system to a more fine-tunable system (meson) will make it easier to support building on other platforms.
This MR also changes the directory structure to be easier to follow for new contributors.
This MR is not ready yet as it has linking issues with assembly files and uses ld.lld on Linux instead of ld64.lld. Also, all directories are not ported to meson yet.
TO TEST THIS MR: