Feature rspec failed with reason #281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inkstak
force-pushed
the
feature-rspec_failed_with_reason
branch
from
cd6e328 to
8ab2319
Compare
inkstak
force-pushed
the
feature-rspec_failed_with_reason
branch
from
8ab2319 to
9aa3c43
Compare
palkan
requested changes
Dec 13, 2024
Comment on lines
+89
to
+100
| case reason | ||
| when nil | ||
| next | ||
| when Hash | ||
| next if subject.reasons.details == reason | ||
| when Symbol | ||
| next if subject.reasons.details.values.flatten.any? { |h| h.include?(reason) } | ||
| when String | ||
| next if subject.reasons.respond_to?(:full_messages) && subject.reasons.full_messages.flatten.include?(reason) | ||
| else | ||
| raise TypeError, "unexpected reason: #{reason.inspect}" | ||
| end |
There was a problem hiding this comment.
I would leave only the Hash matching option but add support for RSpec compound matchers instead:
failed "some desription", reason: a_hash_inclusing(no_admin: true)
For that, we only need to change the order and the == for ===:
reason === subject.reasons.detailsPartial and especially nested matching seems a bit off; if we unit-test policies, we must take care of the actual shape.
I18n is also out of scope, IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
As suggested in this discussion #271, it allows to match reasons when using RSpec DSL
PR checklist: