Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ordering of triggers by name #251

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Conversation

bschrag620
Copy link
Contributor

@bschrag620 bschrag620 commented Oct 3, 2024

Fixes #250

What is the purpose of this pull request?

This PR allows for a configurable option to declare how the ordering of the triggers are generated as part of the schema dump.

What changes did you make? (overview)

  • added a configurable option for Logdize.order_by_trigger_name that defaults to false
  • when set to true, a module is prepended Fx::Adapters::Postgres::Triggers to ensure the returned value is sorted by name

Is there anything you'd like reviewers to focus on?

I'm not sure the best way to test this. I've tested my branch locally against an active project and this is resolving the issue I described.

Checklist

  • I've added tests for this change
  • I've added a Changelog entry
  • I've updated a documentation (Readme)

@bschrag620 bschrag620 marked this pull request as ready for review October 10, 2024 20:15
Copy link
Owner

@palkan palkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

lib/logidze.rb Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@palkan palkan merged commit 5652ac4 into palkan:master Oct 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for trigger ordering to be alphabetical
2 participants