String null fix #2321
Merged
String null fix #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelhwilliams
force-pushed
the
string-null-fix
branch
from
bd0ae74
to
d6458dc
Compare
|
This looks good. I've just fixed up the test cases which needed to switch to some pytest fixtures and tweak indenting. Thanks for contributing 🙏 |
samuelhwilliams
force-pushed
the
string-null-fix
branch
from
d6458dc
to
3e41595
Compare
16 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1840. It is probably worth release noting as it is a behavior change.
Digging into the issue, [this comment](#1840 (comment) points out that String and Text don't handle falsey strings the same way. Digging into the history of the code, the difference originated with this commit which was a fix to #490. The author of that issue only brought up String fields, and the change only fixed String fields. I think it was simply an oversight to not handle Text fields the same way at that time, and it was likely because the opener of the ticket didn't happen to bring up both field types. The two classes were otherwise identical in behavior up until that PR.
The unit tests narrowly dodged the issue. Although there are nullable String columns none of them asserted on the casting of empty string to None, which probably would have made the inconsistency more obvious earlier on.