Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mongoengine date field #2426

Conversation

wangsha
Copy link

@wangsha wangsha commented Apr 19, 2024

fixes: #1921

Copy link
Contributor

@samuelhwilliams samuelhwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a useful change in principle, but right now it doesn't work.

The filter value popup shows a datetime widget, and should probably only show a date widget.

Ideally there should also be some good test coverage for the new field to provide some basic confidence that it works correctly.

I am willing to support this addition in principle, but it is not ready in this current state.


image image

@samuelhwilliams
Copy link
Contributor

I'm going to close this for now, as it doesn't work and is a little old now. There's also some questions around how supportable/maintainable the flask-mongoengine integration is, as it's not really supported any more and that will start to cause issue soon.

Feel free to open again if you want to raise this again.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

DateField for mongoengine absent in admin
2 participants