Skip to content

Debugger security enhancements #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −1
Open

Debugger security enhancements #3020

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8db043a
10 incorrect pins lock debugger
Grezzo Jan 22, 2025
85ffb84
Reject debug cookie if pin exhausted
Grezzo Jan 23, 2025
7703c2b
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/werkzeug/debug/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,11 @@ def check_pin_trust(self, environ: WSGIEnvironment) -> bool | None:
"""
if self.pin is None:
return True

# If we failed too many times, then we're locked out.
if self._failed_pin_auth.value >= 10:
return False

val = parse_cookie(environ).get(self.pin_cookie_name)
if not val or "|" not in val:
return False
Expand Down Expand Up @@ -487,7 +492,7 @@ def pin_auth(self, request: Request) -> Response:
auth = True

# If we failed too many times, then we're locked out.
elif self._failed_pin_auth.value > 10:
elif self._failed_pin_auth.value >= 10:
exhausted = True

# Otherwise go through pin based authentication
Expand Down
Loading