Skip to content

fix(preview): flag unplayable media when previewing a standalone asset #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ctrlaltking wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(preview): flag unplayable media when previewing a standalone asset #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions Sources/PalmierPro/Preview/VideoEngine.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,32 @@ final class VideoEngine {
return
}
replacePlayerItem(AVPlayerItem(url: asset.url), reason: "previewAsset")
verifyAssetPlayable(asset)
}

/// `AVPlayerItem(url:)` fails silently — a corrupt or unsupported file just
/// leaves the preview blank with no error. Probe the tracks so we can flag
/// it through the same offline/unprocessable UI the timeline path uses.
private func verifyAssetPlayable(_ asset: MediaAsset) {
let mediaType: AVMediaType = asset.type == .audio ? .audio : .video
let url = asset.url
let assetId = asset.id
Task { @MainActor [weak self] in
let hasTrack: Bool
do {
hasTrack = try await AVURLAsset(url: url).loadTracks(withMediaType: mediaType).first != nil
} catch {
hasTrack = false
}
guard let self, !Task.isCancelled, let editor = self.editor else { return }
guard case .mediaAsset(let activeId, _, _) = editor.activePreviewTab, activeId == assetId else { return }
if hasTrack {
editor.unprocessableMediaRefs.remove(assetId)
} else {
Log.preview.error("previewAsset: media unplayable assetId=\(assetId.prefix(8))")
editor.unprocessableMediaRefs.insert(assetId)
}
}
}

func activateTab(_ tab: PreviewTab) {
Expand Down