Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new package for events provider #26

Merged
merged 5 commits into from
Apr 28, 2023

Conversation

sreuland
Copy link
Collaborator

Adding new package for soroban events subscriptions. this is to support adding events handling into dapp:

soroban-tools#458:

@esteblock
Copy link
Member

Great! Will check this afternoon

@esteblock
Copy link
Member

esteblock commented Apr 27, 2023

Hello. I merged your first commit c6ea08a

And published in @soroban-react/events v4.3.0
https://www.npmjs.com/package/@soroban-react/events/v/latest

Why to do 5599b9a ?

@esteblock
Copy link
Member

esteblock commented Apr 27, 2023

Also, why to change the dependancy:

"soroban-client": "^0.5.0"

to

"soroban-client": "https://github.com/stellar/js-soroban-client#main"
?
This will carry problems with break changes in soroban-client...
thanks :)

@sreuland
Copy link
Collaborator Author

thank you @esteblock , to respond on questions:

Why to do 5599b9a ?
I reverted that on later commit d4a7dca, I don't think I understood the best way to leverage workspaces yet, still learning about typescript monorepo

Also, why to change the dependancy:
"soroban-client": "^0.5.0"

there was a bug fix committed to main for enabling rpc calls with no params to work - stellar/js-soroban-client@a52897f

Where do you think that version bump will cause issue, I'll look into, I have soroban-example-dapp locally using this updated version of soroban-react(via local file path dependency), it's rendering, however, am seeing a problem with generating xdr from a signed tx for the mint EXT, it's err'ing on DecoratedSignature, which is related to stellar-base and js-xdr which come from soroban-client. maybe we can chat more on discord 'soroban-dev' channel, lmk, thanks!

@sreuland
Copy link
Collaborator Author

@esteblock ,

This will carry problems with break changes in soroban-client...

I'll create 0.5.1 release for js-soroban-client from current main which has the params fix, and update this pr to have packages use 0.5.1

@esteblock
Copy link
Member

Thanks for your answers. What we can do for now is to track an specific commit of soroban-client :)
Will check this tomorrow.

@sreuland
Copy link
Collaborator Author

@esteblock , we cut new js-soroban-client 0.5.1, I pushed change here on pr to pin soroban-client. If what's left on this pr looks good, can you merge and cut new release versions of these packages? I'll make use of them in the soroban-example-dapp pr that is using events , thanks!

@esteblock esteblock merged commit 30ed6b6 into paltalabs:main Apr 28, 2023
@esteblock
Copy link
Member

esteblock commented Apr 28, 2023

Hello, checked. Merged and published version 4.3.1 :)
Now @soroban-react/events v4.3.1 can be used in stellar/soroban-example-dapp#105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants