Skip to content

Conversation

SneakyF0xy
Copy link

  • Fix dependecies
  • Fix network plugin for new wireshark headers
  • Add building for LLVM [There is no apt version]
  • Add building for libosi [No version for 24.04]
  • Fixes small bugs in install script

@AndrewQuijano
Copy link
Collaborator

AndrewQuijano commented Jan 21, 2025

Hello!
Good call out about Ubuntu 24, I just added this to my PR to update LibOSI CI/CD to also include building Ubuntu 24, I will work on adding this to LibOSI now

panda-re/libosi#17
https://github.com/AndrewQuijano/libosi/releases/tag/v0.0.5

A few suggestions:

1- Rather than remove llvm-11 from dependencies, could you do a similar trick like on Ubuntu 18 on install script to have LLVM-11 for Ubuntu 24? Same with the docker image, let's try to avoid changing the installation files as much as possible

2- Seems container build and install_script failed
https://github.com/panda-re/panda/actions/runs/12891265305/job/35944130600?pr=1569

3- Not sure if you use libosi, but if you do, can you check the Debian package made works? Also undo the install libosi building step, since now I have a PR to get libosi to work with Ubuntu 24

4- I am going to get .eggs on gitignore file, so I think it is best to rebase your two commits to one. As the .eggs I think is generated when making PANDA

@AndrewQuijano
Copy link
Collaborator

@stevenjoezhang @SneakyF0xy I just updated LibOSI for it to have Ubuntu 24 package

@SneakyF0xy I have two requests:

1- Please rebase your Pull Request
2- Squash both commits, undo your changes to the installation script
3- Use this approach to install LLVM-11 for Ubuntu 20, 22, 24 in both install_ubuntu and in the Dockerfile
https://apt.llvm.org/
4- Please confirm that the network plugin works as intended for Ubuntu 24, ideally via screenshots or something.

@AndrewQuijano AndrewQuijano marked this pull request as draft May 19, 2025 13:39
return false;
}

int file_type = wtap_pcapng_file_type_subtype();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to call this function AFTER calling wtap_init, or the file types will not yet be registered. (At least that's what I'm seeing with my test case.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants