-
Notifications
You must be signed in to change notification settings - Fork 498
Support for Ubuntu 24.04 Noble #1569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
SneakyF0xy
commented
Jan 21, 2025
- Fix dependecies
- Fix network plugin for new wireshark headers
- Add building for LLVM [There is no apt version]
- Add building for libosi [No version for 24.04]
- Fixes small bugs in install script
…ers, add building LLVM and libosi]
Hello! panda-re/libosi#17 A few suggestions: 1- Rather than remove llvm-11 from dependencies, could you do a similar trick like on Ubuntu 18 on install script to have LLVM-11 for Ubuntu 24? Same with the docker image, let's try to avoid changing the installation files as much as possible 2- Seems container build and install_script failed 3- Not sure if you use libosi, but if you do, can you check the Debian package made works? Also undo the install libosi building step, since now I have a PR to get libosi to work with Ubuntu 24 4- I am going to get .eggs on gitignore file, so I think it is best to rebase your two commits to one. As the .eggs I think is generated when making PANDA |
@stevenjoezhang @SneakyF0xy I just updated LibOSI for it to have Ubuntu 24 package @SneakyF0xy I have two requests: 1- Please rebase your Pull Request |
return false; | ||
} | ||
|
||
int file_type = wtap_pcapng_file_type_subtype(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to call this function AFTER calling wtap_init, or the file types will not yet be registered. (At least that's what I'm seeing with my test case.)