ENH(string dtype): Make str.decode return str dtype #60709
Draft
+25
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
changed the title
rhshadrach
commented
Jan 12, 2025
| @@ -566,7 +566,7 @@ def test_string_slice_out_of_bounds(any_string_dtype): | |||
| def test_encode_decode(any_string_dtype): | |||
| ser = Series(["a", "b", "a\xe4"], dtype=any_string_dtype).str.encode("utf-8") | |||
| result = ser.str.decode("utf-8") | |||
| expected = ser.map(lambda x: x.decode("utf-8")).astype(object) | |||
| expected = Series(["a", "b", "a\xe4"], dtype="str") | |||
There was a problem hiding this comment.
The change from ser.map to using Series is just to make this test a bit more explicit. Using ser.map(...).astype("str") also passes.
jorisvandenbossche
approved these changes
Jan 13, 2025
Comment on lines
+5213
to
+5216
| if get_option("future.infer_string"): | ||
| data = ser.to_numpy() | ||
| else: | ||
| data = ser._values |
There was a problem hiding this comment.
You can probably simplify this and always to .to_numpy()? (or np.asarray(..))
In the case of object dtype in the else branch, that will return the same (and be as cheap) as _values I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.