TST: Add test for exceptional behavior when calling view() on BaseStringArray
#60799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jan 27, 2025
pandas/tests/indexes/test_base.py
Outdated
| @@ -1351,6 +1351,13 @@ def test_index_round(self, decimals, expected_results): | |||
|
|
|||
| tm.assert_index_equal(result, expected) | |||
|
|
|||
| def test_string_array_view_type_error(self): | |||
There was a problem hiding this comment.
Can you move this to pandas/tests/arrays/string_/test_string.py?
There was a problem hiding this comment.
Done. Thanks for the fast feedback @mroeschke I did move it as suggested, let me know if any other change is needed
mroeschke
added
the
Testing
mroeschke
approved these changes
Jan 27, 2025
|
Thanks @MattePalte |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This PR introduces additional tests for the view method of BaseStringArray, which was recently added in PR #60713. The existing test suite did not cover this method, as shown in the coverage reports below. (I also run the entire test suite locally and double checked that the line is not covered).
To verify the tests, you can run:
Note: Currently, running pytest from the root directory is resulting in an error in the coverage collection (regardless of which test). If you have any suggestions on how to resolve this issue, please let me know.
This PR aims to ensure that the
viewmethod is thoroughly tested and meets the pandas testing standards. Your feedback and suggestions are welcome.Coverage Before
Coverage After
Thanks in advance, let me know if you need any more input from my side