Skip to content

Conversation

swt2c
Copy link
Contributor

@swt2c swt2c commented Sep 4, 2025

Backport PR #62210: BUG: Fix Memory Leak in to_json

@swt2c swt2c requested a review from WillAyd as a code owner September 4, 2025 13:37
@jorisvandenbossche
Copy link
Member

Just to understand, how does this relate to #62253 ?

@swt2c
Copy link
Contributor Author

swt2c commented Sep 5, 2025

Both PRs are required to fix the memory leaks. I did two separate backport PRs so it was clear each one was a backport of a different main PR, but if you'd prefer them both in the same backport PR, can do that too?

@Alvaro-Kothe
Copy link
Contributor

Hi @jorisvandenbossche, they fix memory leaks in different types of datetime serializations.

This one fixes in the conversion of datetime to epoch, while the one in #62253 fixes in the conversion of datetime to iso string.

@WillAyd
Copy link
Member

WillAyd commented Sep 5, 2025

This lgtm. Pretty sure the pre-commit error is unrelated - @jorisvandenbossche can that be re-run?

@jorisvandenbossche
Copy link
Member

Ah, sorry, I missed that there were two PRs to main

Pretty sure the pre-commit error is unrelated - @jorisvandenbossche can that be re-run?

Yeah, pre-commit.ci is timing out on 2.3.x, so just ignore this (we should maybe disable it to avoid the confusion)

@jorisvandenbossche jorisvandenbossche added this to the 2.3.3 milestone Sep 5, 2025
@jorisvandenbossche jorisvandenbossche merged commit 4b525ca into pandas-dev:2.3.x Sep 5, 2025
51 of 52 checks passed
@swt2c swt2c deleted the backport_pr_62210 branch September 5, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants