When finding the common type, return the original type if there is on… #62913
+40
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 29, 2025 20:42
…ly one common type. Return objects for date32 and date64 types when converting those types to numpy types.
jbrockmendel
reviewed
Nov 4, 2025
| # try a pyarrow dtype | ||
| from pandas.core.dtypes.dtypes import ArrowDtype | ||
| if isinstance(dtype, ArrowDtype): | ||
| return ArrowDtype(dtype) |
There was a problem hiding this comment.
do we ever get here? Seems like these cases would be caught above
jbrockmendel
reviewed
Nov 4, 2025
| if pa.types.is_date32(self.pyarrow_dtype) or pa.types.is_date64( | ||
| self.pyarrow_dtype | ||
| ): | ||
| # date32 and date64 are pyarrow timestamps but do not have a |
There was a problem hiding this comment.
nitpick they are not "pyarrow timestamps"
jbrockmendel
reviewed
Nov 4, 2025
| ): | ||
| # date32 and date64 are pyarrow timestamps but do not have a | ||
| # corresponding numpy dtype. | ||
| return np.dtype(object) |
There was a problem hiding this comment.
np.datetime64[D] might be more reasonable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When finding a common type, return the original type if there is only one non-null type.
When getting the numpy datatype, return objects for date32 and date64 types.
#62343
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.