Repository navigation
chore: remove stale autopilot fixture imports - #469
Open
pandemicsyn wants to merge 1 commit into
Open
pandemicsyn wants to merge 1 commit into
pandemicsyn wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change only removes unused local imports, with no affected execution paths or unresolved findings.
No open issues 🎉
What changed in this PR
Removes four unused GitHub fetch imports from the Autopilot fixture adapter. The adapter continues using injected callbacks and fixture data, with no expected runtime behavior change.
Changes:
- Deletes unused imports for pull request events, check summaries, failing checks, and pull request details.
- Preserves required GitHub type imports and fixture logic.
| File | Description |
|---|---|
src/modules/autopilot/fixtures.ts |
Removes four unused GitHub fetch bindings. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dead-code removal: removes four unused GitHub fetch bindings from the Autopilot fixture adapter.
Safety evidence
--noUnusedLocals --noUnusedParametersidentified each removed binding as unread.dependencies.fetch*callbacks and fixture data instead.dependenciesWithAutopilotFixtureremains imported by the live Autopilot worktree preparation path; its required GitHub type imports remain, so the../githubmodule continues loading exactly as before.Validation
vitest run --config vitest.unit.config.ts src/autopilot-loop.test.ts(41 passed)npm run typecheck:appnpm run buildnpm run check:npm-packagenpm run smoke:npm-packnpm run format:checkgit diff --checknpm run verifypassed lint (existing warnings), import-layer, migration, and type checks, then the unit suite completed with 3,556 passing tests and 9 unrelated host-sensitive failures: temporary-worktree cleanup races, report/automation shared-state expectations, and a process-death timeout.Residual uncertainty
No runtime behavior should change because only unread local bindings were removed. The full unit-suite failures need separate stabilization; they do not exercise this fixture import change.