Skip to content

chore: remove stale autopilot fixture imports - #469

Open
pandemicsyn wants to merge 1 commit into
mainfrom
agent/weekly-code-health-2026-10-23
Open

pandemicsyn wants to merge 1 commit into
mainfrom
agent/weekly-code-health-2026-10-23

Conversation

@pandemicsyn

Copy link
Copy Markdown
Owner

Summary

Dead-code removal: removes four unused GitHub fetch bindings from the Autopilot fixture adapter.

Safety evidence

  • TypeScript --noUnusedLocals --noUnusedParameters identified each removed binding as unread.
  • Exact source scans found the names in this module only in the import declaration or as distinct dependency-property names; the adapter reads dependencies.fetch* callbacks and fixture data instead.
  • dependenciesWithAutopilotFixture remains imported by the live Autopilot worktree preparation path; its required GitHub type imports remain, so the ../github module continues loading exactly as before.
  • Repository scans covered direct references, exports, route/tool registration, dynamic imports, filesystem discovery, configuration, scripts, and tests; none can resolve these non-exported local bindings.

Validation

  • vitest run --config vitest.unit.config.ts src/autopilot-loop.test.ts (41 passed)
  • npm run typecheck:app
  • npm run build
  • npm run check:npm-package
  • npm run smoke:npm-pack
  • npm run format:check
  • git diff --check

npm run verify passed lint (existing warnings), import-layer, migration, and type checks, then the unit suite completed with 3,556 passing tests and 9 unrelated host-sensitive failures: temporary-worktree cleanup races, report/automation shared-state expectations, and a process-death timeout.

Residual uncertainty

No runtime behavior should change because only unread local bindings were removed. The full unit-suite failures need separate stabilization; they do not exercise this fixture import change.

Copilot AI balanced review requested due to automatic review settings October 23, 2026 15:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change only removes unused local imports, with no affected execution paths or unresolved findings.

No open issues 🎉

What changed in this PR

Removes four unused GitHub fetch imports from the Autopilot fixture adapter. The adapter continues using injected callbacks and fixture data, with no expected runtime behavior change.

Changes:

  • Deletes unused imports for pull request events, check summaries, failing checks, and pull request details.
  • Preserves required GitHub type imports and fixture logic.
File Description
src/​modules/​autopilot/​fixtures.ts Removes four unused GitHub fetch bindings.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants