Skip to content

chore: remove stale Autopilot fixture type import - #472

Open
pandemicsyn wants to merge 1 commit into
mainfrom
agent/weekly-code-health-2026-10-26
Open

pandemicsyn wants to merge 1 commit into
mainfrom
agent/weekly-code-health-2026-10-26

Conversation

@pandemicsyn

Copy link
Copy Markdown
Owner

Cleanup type

Dead-code removal. This run did not use the duplication fallback.

What changed

Removed the unused, explicitly type-only JsonValue import from src/modules/autopilot/fixtures.ts.

Safety evidence

  • Audited clean origin/main at 8cc12efa64d996962574918d75321b1f44e4339f in an isolated worktree.
  • TypeScript run with --noUnusedLocals --noUnusedParameters reported this import as unused; after removal, that specific diagnostic is absent.
  • JsonValue had no other reference in the fixture module and is not an export, route, plugin, script, configuration value, runtime registration, or string/reflection lookup target.
  • The import used TypeScript's type modifier, so it is erased and cannot initialize or otherwise affect @flue/runtime at runtime.
  • The live fixture entry point remains a normal static import from src/modules/autopilot/worktree.ts; repository searches found no dynamic import or discovery path for the removed symbol. The source is handwritten, not generated.
  • Reviewed the final diff: one deleted line in the intended file only.

Validation

  • Passed: npm exec vitest -- run --config vitest.unit.config.ts src/autopilot-loop.test.ts --fileParallelism=false — 41 tests.
  • Passed: git diff --check.
  • npm run verify was attempted using available Node 26.12.1; the prescribed Node 26.4.0 is not installed. Lint, import-layer, DB migration, app/dashboard/docs typecheck stages passed (with existing lint warnings). The unit stage then failed in unrelated files: 2 assertions in src/learning-automation.test.ts, 2 in src/reports.test.ts, and 1 in src/modules/repo-workflow-runs/service.test.ts, so later aggregate stages did not run.

Residual uncertainty

No behavioral uncertainty is expected: the removed TypeScript type import is compile-time only. The only validation limitation is the unrelated full-suite unit failures above.

Copilot AI balanced review requested due to automatic review settings October 26, 2026 13:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The single-line cleanup removes an unreferenced type-only import with no identified correctness issues.

No open issues 🎉

What changed in this PR

Removes an unused type-only import from the Autopilot fixture module without changing runtime behavior.

Changes:

  • Deletes the stale JsonValue import from @flue/runtime; fixture logic and exports remain unchanged.
File Description
src/​modules/​autopilot/​fixtures.ts Removes one unused type-only import.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants