Reactivate Retraction Logic #69
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just got access to the public bucket back, and that seems to work. This job still fails, but it is not because the authentication!
In this PR I am applying a few things that I have learned over the past.
replicakeyword for the ESGF query is quite confusing to me. Writing this I wrongly assumed that setting this to false I would only get the results for all the (distributed) master records, but after my recent experience I am not so sure about that. According to the ESGF API repo I believe just leaving this as the default it the way to go.That last job timed out because it would time out for the dkrz node, so I am deactivating that for now.