Feat: nbproxy and vscode #597
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
guillaumeeb
reviewed
Apr 10, 2025
There was a problem hiding this comment.
Thanks for this PR, main comments here:
- Lot of duplications of script and content, this should not be necessary
- Main duplicated content should be if possible implemented properly as a Jupyterlab extension in another repository. The code linked to VSCode should not be implemented here.
| tmux | ||
| tree | ||
| unzip | ||
| vim No newline at end of file |
There was a problem hiding this comment.
Are all this dependencies really needed for this particular change? I feel some are just here for adding tools, but could be in another PR?
| setuptools.setup( | ||
| name="jupyter-proxy", | ||
| version="0.0.1", | ||
| url="https://github.com/jupyterhub/jupyter-server-proxy/tree/master/contrib/theia", |
There was a problem hiding this comment.
This installation process looks complicated, especially in this repo. Couldn't we build a better extension system, maybe in the repo linked above, so that such an extension could be easily installed with standard Jupyter toolset?
| tig | ||
| tmux | ||
| tree | ||
| unzip |
There was a problem hiding this comment.
Is this normal to have to repeat all the apt package again in ml-notebook?
| tree | ||
| unzip | ||
| vim | ||
| nano |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add nbproxy and vscode to base-notebook, pangeo-notebook, pytorch-notebook and ml-notebook.
Needs #600 to be merged before merging this one.