add util to build tripolar grid #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaeldussin
force-pushed
the
tripolar_util
branch
from
254e9f4 to
1b9dd99
Compare
Contributor
Author
|
@huard @aulemahal this implements the |
huard
approved these changes
Jan 23, 2023
Contributor
huard
left a comment
huard
left a comment
There was a problem hiding this comment.
I suggest making bipolar_projection and generate_bipolar_cap_mesh private functions.
Co-authored-by: David Huard <[email protected]>
for more information, see https://pre-commit.ci
huard
approved these changes
Jan 23, 2023
Contributor
Author
|
@aulemahal friendly reminder |
aulemahal
approved these changes
Jan 27, 2023
Collaborator
aulemahal
left a comment
aulemahal
left a comment
There was a problem hiding this comment.
I do not have much knowledge of tripolar grids, but this code looks fine!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #223 uses data files that are too big, this PR adds code to build a simple (simplistic?) tripolar grid for testing purposes only. PR #223 could then use this function to generate its own tests with synthetic data from a tripolar grid to a regular grid using some type of field (e.g. sin(lat) )