-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop -> Master #501
Merged
Develop -> Master #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this just makes the indentation increase with an initial dot chained method
* incorrect change in cursor pos some bizarre problem which made me invent a buggy fix. also reindented the file
This PR should add far more complete support for destructuring, both in var/let/const statements and also within function argument definitions. There may be some cases I have not tested and are broken, therefore more testing is for sure needed.
Rest and spread operators are now clearly different, and also create real regions that match more accurately.
Improvements To Destructuring
seems to fix #491, may be necessary to look for a more complex solution if this causes regressions
since cindent considers single quotes as delimiting a single char string, cindent will break in situations like : https://github.com/sanctuary-js/sanctuary-def/blob/master/index.js#L222 http://stackoverflow.com/questions/3683602/single-quotes-vs-double-quotes-in-c
This is by no means complete, and so far has only been to fix major syntax highlighting issues I've found.
Also linked jsFlowNoise to Noise
Fixes #288
syntax include has a sort of sugar to it that forces all sourced highlighting to be contained, this will break certain more general highlighting for jsFlow. runtime on the other hand, works exactly as you'd expect.
* JSDocs are now hidden behind a variable for consistency with other plugins * NGDoc plugin can now only be enabled if JSDoc is enabled. * Added README documentation for the new global booleans
JS Flow Annotation Support and A Proper Plugin System
First pass at improved export support
develop seems quite stable to me. thanks! |
Removed some seemingly needless regexes, updated to match consistency
jsComment updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bunch of new features and indentation fixes.
Features includes: