Repository navigation
fix(mcp): load trusted compiler for template scans - #452
Merged
Merged
Conversation
Parse project templates with the compiler bundled by the package, not code selected from scanned project dependencies. Keep Angular-version-specific findings aligned with the project's declared version. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 35 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
github-actions
Bot
added
area: package
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
|
View your CI Pipeline Execution ↗ for commit a217a93
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Template scans previously imported
@angular/compilerthrough the scanned project's package resolution, allowing project-controlled code to execute with the scanner's authority. Bundle and load the package's compiler instead, and use the project's declared Angular major only for version-specific lint behavior.How it was verified
pnpm commit:check(1 commit message OK)pnpm format:checkpnpm typecheckpnpm test,pnpm test:devtoolsandpnpm test:panel(workspace and panel tests passed;pnpm test:devtoolshas one failure inhub-entry.test.ts)pnpm skills:check(when.claude/changed)apps/docsupdated andpnpm docs:buildpasses (when behavior, options, UI labels or agent tools changed), or theno-docslabel added with the reason belowpnpm extension:buildandextension/uicommitted (whenapp/changed)Additional checks:
pnpm typecheck,pnpm build,pnpm extension:build,pnpm docs:build, andpnpm exec nx affected -t test buildpassed. The two focused template compiler test files passed (43 tests). Axe checks passed using installed Chrome with the Playwright script; the standard command could not download its pinned Chromium.Screenshots
N/A. No UI changes.
Notes for reviewers
The failing package test expects a missing built hub entry, but
pnpm devtools:build-pkgcreates that entry before the test runs. No change in this PR touches the hub loader.