Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix the inconsistent behaviors on Windows #510

Merged
merged 1 commit into from
Oct 19, 2023
Merged

bug: fix the inconsistent behaviors on Windows #510

merged 1 commit into from
Oct 19, 2023

Conversation

panjf2000
Copy link
Owner

No description provided.

@github-actions github-actions bot added bug Something isn't working docs labels Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (bcc291f) 77.04% compared to head (a6a1878) 77.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #510      +/-   ##
==========================================
+ Coverage   77.04%   77.55%   +0.50%     
==========================================
  Files          25       25              
  Lines        2466     2490      +24     
==========================================
+ Hits         1900     1931      +31     
+ Misses        430      427       -3     
+ Partials      136      132       -4     
Flag Coverage Δ
unittests 77.55% <100.00%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
connection_unix.go 73.43% <100.00%> (+1.87%) ⬆️
connection_windows.go 66.76% <100.00%> (+2.45%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 merged commit 5710ad4 into dev Oct 19, 2023
33 checks passed
@panjf2000 panjf2000 deleted the bug509 branch October 19, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant