Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: eliminate the inuse eventloop.cache for idle connections #660

Merged
merged 4 commits into from
Nov 16, 2024

Conversation

panjf2000
Copy link
Owner

Fixes #659

@github-actions github-actions bot added the enhancement New feature or request label Nov 16, 2024
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.58%. Comparing base (db2fad2) to head (e2b890f).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
connection_unix.go 76.47% 4 Missing ⚠️
connection_windows.go 76.47% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #660      +/-   ##
==========================================
+ Coverage   78.75%   79.58%   +0.82%     
==========================================
  Files          21       21              
  Lines        2551     2537      -14     
==========================================
+ Hits         2009     2019      +10     
+ Misses        422      398      -24     
  Partials      120      120              
Flag Coverage Δ
unittests 79.58% <76.47%> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 added the optimization Some small optimizations label Nov 16, 2024
@panjf2000 panjf2000 merged commit 451f015 into dev Nov 16, 2024
34 of 35 checks passed
@panjf2000 panjf2000 deleted the eventloop-cache branch November 16, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization Some small optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: the buff of eventloop.cache used cannot be released
1 participant