Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libraries self implementations #5

Merged
merged 25 commits into from
Oct 5, 2023
Merged

Libraries self implementations #5

merged 25 commits into from
Oct 5, 2023

Conversation

guil-lambert
Copy link
Contributor

No description provided.

guil-lambert and others added 18 commits October 4, 2023 11:19
@guil-lambert
feat: rolling out own TickMath implementations
295c928
@guil-lambert
test: added comparative tests
1c41677
@guil-lambert
test: reduced fuzz runs
51f6b82
@guil-lambert
feat: started rolling out own implementation of LiquidityAmounts
0acb8d7
@guil-lambert
test: added getAmount tests
0c7b8d9
@guil-lambert
feat: added getLiquidityForAmount functions
cb98d2f
@guil-lambert
test: added getLiquidity tests
2fb44d9
Fix code style issues with Prettier
ecb4ec4
@guil-lambert
feat: removed TickMath and LiquidityAmounts libraries
d072750
@guil-lambert
Merge branch 'libraries-self-implementations' of https://github.com/p…
b05074a 
…anoptic-labs/panoptic-v1-core into libraries-self-implementations
Fix code style issues with Prettier
1432f91
@guil-lambert
chore: expanded expression into numbers
9a5f427
@guil-lambert
Merge branch 'libraries-self-implementations' of https://github.com/p…
6dc6db3 
…anoptic-labs/panoptic-v1-core into libraries-self-implementations
@guil-lambert
docs: added natspecs
f845100
Fix code style issues with Prettier
363525b
@guil-lambert
docs: added comments in getTickAtSqrtRatio
cf5ae0d
@guil-lambert
Merge branch 'libraries-self-implementations' of https://github.com/p…
3be165d 
…anoptic-labs/panoptic-v1-core into libraries-self-implementations
Fix code style issues with Prettier
f6bc560
@guil-lambert guil-lambert marked this pull request as ready for review October 4, 2023 18:20
dyedm1
dyedm1 requested changes Oct 4, 2023
View reviewed changes
Copy link
Member

@dyedm1 dyedm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just have a couple changes/optimizations.

contracts/CollateralTracker.sol Outdated Show resolved Hide resolved
contracts/CollateralTracker.sol Show resolved Hide resolved
contracts/types/LiquidityChunk.sol Outdated Show resolved Hide resolved
contracts/libraries/Math.sol Outdated Show resolved Hide resolved
contracts/libraries/Math.sol Outdated Show resolved Hide resolved
contracts/libraries/Math.sol Outdated Show resolved Hide resolved
contracts/libraries/Math.sol Outdated Show resolved Hide resolved
contracts/libraries/Math.sol Outdated Show resolved Hide resolved
contracts/libraries/FeesCalc.sol Outdated Show resolved Hide resolved
contracts/libraries/Math.sol Show resolved Hide resolved
dyedm1
dyedm1 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@dyedm1 dyedm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass!

@guil-lambert guil-lambert merged commit df0b612 into main Oct 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyedm1 dyedm1 dyedm1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guil-lambert @dyedm1