catch throwable instead of exception

[heddn]

Attempt to fix #2254

[heddn]

That seemed to do the trick. I tested it via https://github.com/heddn/terminus/releases/tag/login_throwable.

[greg-1-anderson]

I'm right on the edge of accepting this. I'd really like to be able to reproduce this locally and understand what the problem is rather than mask the symptom. My worry is that implementing catch-all solutions that are too broad runs the risk of changing behavior during error conditions. It's hard to prove the absence of adversely-affected error conditions.

That said, this particular PR is isolated to just one part of the login process, so it is at least safer than a similar change e.g. to TerminusCollections::fetch().

Can you provide a series of steps that could be done (e.g. creating folders / files in the Terminus cache dir) that would allow this to be reproduced locally, outside of CI / Lando?

[heddn]

Can you provide a series of steps that could be done (e.g. creating folders / files in the Terminus cache dir) that would allow this to be reproduced locally, outside of CI / Lando?

Unfortunately, I wasn't able to reproduce it locally. That would make this whole thing easier. But for now, I've moved back to PHP 7.4 and Terminus 2.

After using my phar file, I was running into more errors with terminus drush $pantheon_site.$pantheon_env -- site:install -v --existing-config --yes --sites-subdir=default. It was complaining about SQLSTATE[42S02]: Base table or view not found: 1146 Table 'pantheon._pantheon_heartbeat' doesn't exist. More things need to be stable in the v3 terminus branch for me to use it.

I'm back on PHP 8.0 with the PHAR I built above. I figured out my issues with the SQLSTATE error was a stupid oversight on my part unrelated to what we are seeing here.

[greg-1-anderson]

We've decided this isn't a blocker for the 3.0.0 stable release. We can continue to consider fixes to go out in a follow-on bugfix release.

[heddn]

Hmm, #2231 might actually be the solution here.