Add Redis clear #2355
Draft
Add Redis clear #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @usage <site>.<env> Clears caches for <site>'s <env> environment. | ||
| * | ||
| * @throws \Pantheon\Terminus\Exceptions\TerminusProcessException | ||
| * @throws \Pantheon\Terminus\Exceptions\TerminusException | ||
| */ | ||
| public function clearCache($site_env) | ||
| public function clearCache($site_env, $options = ['framework_cache' => true, 'varnish_cache' => false,]) |
There was a problem hiding this comment.
-1 on adding flags to the existing env:cc command. Note that it's not reliable to turn off the varnish cache here, as the Drupal hook will clear the varnish cache even if the ygg workflow does not.
The existing behavior may be inconsistent with WordPress, i.e. WordPress might not clear the varnish cache if the ygg workflow does not. Ideally we would fix WordPress, and hook its cache clear operation the same way we do for Drupal. Maybe having ygg clear the varnish cache invariantly here would be a reasonable workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a Redis cache clear option available in the platform, but it is not yet exposed as a command within Terminus. This will add a new
redis:clearcommand that runs on an environment.In addition, this also adds Varnish as an option when clearing the cache as right now we only clear the framework cache (ie,
drush crorwp cache flush).